Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Notification Condition for Scheduled Test Runs #8115

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update Notification Condition for Scheduled Test Runs #8115

merged 1 commit into from
Dec 12, 2024
+4 −86

Conversation

kachawla
Copy link
Contributor

@kachawla kachawla commented Dec 10, 2024 •
edited
Loading

Description

Updating scheduled test run notification logic. With this update every scheduled functional/long running test run failure will log a new issue.

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #7998

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue. -- N/A
  • A design document PR is created in the design-notes repository, if new APIs are being introduced. -- N/A
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers. -- N/A
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR. -- N/A
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made. -- N/A
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR. -- N/A

@kachawla kachawla requested review from a team as code owners December 10, 2024 00:49
@kachawla kachawla changed the title Update Notification Conditions for Scheduled Test Runs Update Notification Condition for Scheduled Test Runs Dec 10, 2024
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 10, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref d2c10c6
Unique ID func3ec6f133fe
Image tag pr-func3ec6f133fe
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3ec6f133fe
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3ec6f133fe
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func3ec6f133fe
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func3ec6f133fe
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3ec6f133fe
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details
⌛ Starting corerp-cloud functional tests...
❌ corerp-cloud functional test failed. Please check the logs for more details

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.63%. Comparing base (dcf5ad6) to head (65b6cd8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8115      +/-   ##
==========================================
- Coverage   59.64%   59.63%   -0.01%     
==========================================
  Files         577      577              
  Lines       38573    38573              
==========================================
- Hits        23007    23004       -3     
- Misses      13918    13920       +2     
- Partials     1648     1649       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sk593
sk593 previously approved these changes Dec 11, 2024
View reviewed changes
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 11, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 261d2b6
Unique ID func434c50cde0
Image tag pr-func434c50cde0
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func434c50cde0
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func434c50cde0
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func434c50cde0
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func434c50cde0
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func434c50cde0
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
❌ ucp-cloud functional test failed. Please check the logs for more details

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 11, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref be58645
Unique ID func1598d96076
Image tag pr-func1598d96076
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1598d96076
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1598d96076
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1598d96076
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1598d96076
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1598d96076
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
❌ corerp-cloud functional test failed. Please check the logs for more details

ytimocin
ytimocin previously approved these changes Dec 11, 2024
View reviewed changes
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 11, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref a7b205c
Unique ID funcc8ff331d0b
Image tag pr-funcc8ff331d0b
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc8ff331d0b
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc8ff331d0b
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc8ff331d0b
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc8ff331d0b
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc8ff331d0b
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 11, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref afc5728
Unique ID func1f54e760ed
Image tag pr-func1f54e760ed
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1f54e760ed
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1f54e760ed
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1f54e760ed
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1f54e760ed
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1f54e760ed
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 12, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 5cff550
Unique ID func1cf8defbca
Image tag pr-func1cf8defbca
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func1cf8defbca
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func1cf8defbca
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func1cf8defbca
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func1cf8defbca
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func1cf8defbca
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 12, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 38a60bb
Unique ID func3ac98c67c5
Image tag pr-func3ac98c67c5
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func3ac98c67c5
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func3ac98c67c5
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func3ac98c67c5
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func3ac98c67c5
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func3ac98c67c5
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla
Update scheduled test run notification logic.
65b6cd8 
With this update every scheduled functional/long running test run failure will log a new issue.

Signed-off-by: karishma-chawla <[email protected]>
@kachawla kachawla dismissed stale reviews from sk593 and ytimocin via 65b6cd8 December 12, 2024 18:26
@radius-functional-tests
Copy link

radius-functional-tests bot commented Dec 12, 2024 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 65b6cd8
Unique ID funcc3877014d4
Image tag pr-funcc3877014d4
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcc3877014d4
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcc3877014d4
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcc3877014d4
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcc3877014d4
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcc3877014d4
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla kachawla requested a review from nicolejms December 12, 2024 18:32
@kachawla kachawla merged commit 13df9da into radius-project:main Dec 12, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sk593 sk593 sk593 approved these changes

@ytimocin ytimocin ytimocin left review comments

@nicolejms nicolejms Awaiting requested review from nicolejms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Automated GitHub Issues for Scheduled Test Run Failures
3 participants
@kachawla @ytimocin @sk593